Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error on incorrect cairo linting #35

Merged
merged 4 commits into from
Feb 18, 2022
Merged

Conversation

Orland0x
Copy link
Contributor

@Orland0x Orland0x commented Feb 18, 2022

Need to throw error if the code was not correctly linted so that the linting github action will fail in that scenario. The -c param is required for this.

Copy link
Contributor

@pscott pscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the return value of cairo-format checked somewhere ?

@pscott
Copy link
Contributor

pscott commented Feb 18, 2022

I added a commit which does two things:

  1. Add a check-format script to the package.json file, and renamed the lint script to format. This way developers can run yarn format to actually format the files, and our CI can use check-format to ensure correct formating.
  2. Modify our github action to call check-format rather than lint :)

I've force-pushed the branch because I tested my work with two dummy commits that i removed to keep a clean history. Here's a screenshot to prove my claim https://imgur.com/a/IpznhxJ

@pscott pscott mentioned this pull request Feb 18, 2022
@Orland0x Orland0x merged commit 388d20c into develop Feb 18, 2022
@Orland0x Orland0x deleted the Orland0x-patch-1 branch February 18, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants