Formatting and Comments #364
Conversation
|
Does this follow the Orlando standard? |
yep :)) |
Orland0x
changed the title
| // @param target Address of the space contract | ||
| // @param function_selector Function selector of the action | ||
| // @param calldata Calldata array required for the action | ||
| // @param session_public_key The StarkNet session public key that was used to generate the signature |
There was a problem hiding this comment.
since this is an external function, should it be sessionPublicKey? or is it only for function names and not the arguments?
There was a problem hiding this comment.
Ive just been reading some OZ examples and they actually seem to use a mixture. eg:
snake case here:
https://github.com/OpenZeppelin/cairo-contracts/blob/893f4b98739bdc1b7d64d0511d96d19f290eef88/src/openzeppelin/token/erc20/presets/ERC20.cairo#L89
but then camel here:
https://github.com/OpenZeppelin/cairo-contracts/blob/893f4b98739bdc1b7d64d0511d96d19f290eef88/src/openzeppelin/account/presets/Account.cairo#L48
Ill reach out to OZ and clarify
There was a problem hiding this comment.
what a mess this casing is haha
| // We don't need to pad because calling `.address` with starknet.js | ||
| // already left pads the address with 0s |
There was a problem hiding this comment.
Might be interesting to keep this comment?
There was a problem hiding this comment.
Actually, might be worth leaving the padding on-chain so that the signed message is more readable in users wallet.
See this issue: snapshot-labs/sx.js#92
There was a problem hiding this comment.
See my comment in the issue you posted :) I think we should still keep the comment! :)
Added comments and some general formatting/cleaning up
executortoexecution_strategyas we had a mix of the terms.voting_strategy_params_flatis aftervoting_strategiesin the constructor args.update_*functions toset_*closes #210
closes #367