Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

moved ownership library to contract level #377

Merged
merged 1 commit into from
Nov 10, 2022
Merged

moved ownership library to contract level #377

merged 1 commit into from
Nov 10, 2022

Conversation

Orland0x
Copy link
Contributor

@Orland0x Orland0x commented Oct 26, 2022 •
edited
Loading

closes #366

@Orland0x Orland0x marked this pull request as ready for review October 26, 2022 11:39
@Orland0x Orland0x requested a review from pscott October 26, 2022 13:38
pscott
pscott approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@pscott pscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup!

@Orland0x Orland0x merged commit 462f95c into develop Nov 10, 2022
Orland0x added a commit that referenced this pull request Nov 10, 2022
@Orland0x
moved owner lib (#377) (#383)
2063388
Orland0x added a commit that referenced this pull request Nov 22, 2022
@Orland0x
Add merkle whitelist voting strategy (#384)
2e7e70e 
* moved owner lib (#377) (#383)

* merkle lib

* merkle lib test

* added failure test for merkle lib

* Merkle Whitelist and test

* added documentation comments

* formatting

* fixed typo

* more tests for merkle lib
@Orland0x Orland0x deleted the ownership branch November 25, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pscott pscott pscott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move ownership checks to contracts instead of in libraries
2 participants
@Orland0x @pscott