add Execution #67
Merged
add Execution #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is finally ready! |
pscott
commented
Apr 1, 2022
contracts/starknet/space/space.cairo
Outdated
Comment on lines
109
to
110
| # TODO: L1 needs to know about L2 address, but L2 needs to know about the L2 address... need to fix that. | ||
| # TODO: this should either be on the l1 contract or the l2 contract. Since l1 contract has an `owner` I think it should be on l1. |
There was a problem hiding this comment.
This needs to be addressed (we can merge like this, but will definitely need to be addressed soon)
pscott
commented
Apr 1, 2022
test/starknet/shared/helpers.ts
Outdated
Comment on lines
55
to
56
| // This should be declared along with the other const but doing so will make the compiler unhappy as `SplitUin256` | ||
| // will be undefined for some reason? |
There was a problem hiding this comment.
I need some TS gods to help me here... initially had it along with the other consts but it simply didn't work ^^
|
Currently working on adding:
|
…into add_execution
|
Im wondering whether the entire proposal should be cancelled if overflow on the voting power count happens rather than just making that vote fail. The proposal is broken if it happens so seems like it should be cancelled |
Orland0x
reviewed
Apr 10, 2022
Orland0x
reviewed
Apr 11, 2022
Orland0x
reviewed
Apr 11, 2022
Orland0x
reviewed
Apr 14, 2022
Orland0x
reviewed
Apr 14, 2022
bonustrack
approved these changes
Apr 15, 2022
Orland0x
approved these changes
Apr 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
executionfeature.Basically, this PR adds a
finalize_proposalmethod to thespacecontract, and adds azodiac_relayer.cairocontract that will relay the execution to L1. L1 smart-contract is also modified to have a mapping of whitelisted Spaces that can trigger the execution.This
finalize_proposalcan be called by anyone, but only after theproposal_periodhas ended.It sends a message to the execution contract stored in
executor, and notes the proposal asexecuted. It is up to the execution contract to decide what to do with the information provided.