Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SolarView: Allow configuration of command #1958

Merged
merged 6 commits into from
Jan 24, 2022

Conversation

git-developer
Copy link
Contributor

This PR contains:

  • A fix for a bug that was introduced when the original shell script was moved to python.
  • A new feature to read a custom command from the configuration file, as requested in the forum. This allows users to configure a single inverter as relevant for openWB, and not the whole plant.

The original contribution was #245.

Copy link
Collaborator

@benderl benderl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Danke für den PR und Bugfix.
Kannst Du bitte noch meine Kommentare beachten?

runs/updateConfig.sh Show resolved Hide resolved
web/settings/modulconfigpv.php Show resolved Hide resolved
web/settings/modulconfigpv.php Show resolved Hide resolved
@benderl benderl self-assigned this Jan 24, 2022
@benderl benderl added Bugfix This pull request adresses one or more bugs enhancement New feature or request labels Jan 24, 2022
@benderl benderl merged commit 8478b6e into snaptec:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix This pull request adresses one or more bugs enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants