Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo/Delete Boosts not being federated AP => Bluesky #1127

Closed
TomCasavant opened this issue Jun 10, 2024 · 3 comments
Closed

Undo/Delete Boosts not being federated AP => Bluesky #1127

TomCasavant opened this issue Jun 10, 2024 · 3 comments
Labels

Comments

@TomCasavant
Copy link

Accidentally boosted a post using mastodon, removed it and then was surprised to see it was still boosted on the bluesky side a few hours later

Tested it with a few other posts and got the same result

Screenshot_20240610_193923_Tom-Moshidon Debug.jpg

Screenshot_20240610_193939_Tom-Moshidon Debug.jpg

Screenshot_20240610_193900_Bluesky.jpg

Screenshot_20240610_193910_Bluesky.jpg

Here are the links if that helps:
https://bsky.app/profile/mmasnick.bsky.social/post/3kum5klb2rk2f
https://bsky.app/profile/samuel.bsky.team/post/3kum434yavl2g

@snarfed
Copy link
Owner

snarfed commented Jun 10, 2024

Ooh, good catch! This is almost certainly because undoing a boost is an Undo, not a Delete, and I think we only handle Undos of Follows right now. Should be straightforward to add support.

@snarfed
Copy link
Owner

snarfed commented Jun 30, 2024

Done! Also for likes, undoing those works now too.

(Also, this was suspiciously easy. The diff for 22d6cef is...well, there's kind of nothing to it. Doesn't happen often, but every now and then, all the parts are already in place, and all you have to do is hook them up. Feels good man.)

@snarfed
Copy link
Owner

snarfed commented Jun 30, 2024

Also confirmed that this is working the other way, Bluesky => fediverse.

@snarfed snarfed closed this as completed Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants