Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP reply to unbridged accounts/posts is bridged to Bluesky #1166

Closed
TomCasavant opened this issue Jul 6, 2024 · 4 comments
Closed

AP reply to unbridged accounts/posts is bridged to Bluesky #1166

TomCasavant opened this issue Jul 6, 2024 · 4 comments
Labels
now

Comments

@TomCasavant
Copy link

https://bsky.app/profile/tom.tomkahe.com.ap.brid.gy/post/3kwl2m5dvwcz2

https://tomkahe.com/@tom/112736397018480884

possibly because the reply is too long so it's skipping over something when it truncates?

I see the same thing in these
https://bsky.app/profile/laurenshof.indieweb.social.ap.brid.gy/post/3kwjidaqxh2d2 (same thread as above)

https://bsky.app/profile/laurenshof.indieweb.social.ap.brid.gy/post/3kwjidaqxh2d2
https://bsky.app/profile/laurenshof.indieweb.social.ap.brid.gy/post/3kwjirhhhz7d2
@snarfed
Copy link
Owner

snarfed commented Jul 6, 2024

Thanks for reporting! Looks like #1047 took us from too conservative to too liberal. Will fix.

@snarfed snarfed added the now label Jul 6, 2024
@snarfed
Copy link
Owner

snarfed commented Jul 7, 2024

May be a simple fix for a dumb bug, I'm guessing the answer is to start the conditional here with if is_reply and ...:

bridgy-fed/protocol.py

Lines 1270 to 1274 in dd21c6c

# deliver self-replies to followers
# https://github.com/snarfed/bridgy-fed/issues/639
if owner == as1.get_owner(orig_obj.as1):
is_self_reply = True
logger.info(f'Looks like a self reply! Delivering to followers')

Need to confirm that that's actually the cause first.

snarfed added a commit that referenced this issue Jul 9, 2024
@snarfed
Protocol.targets: skip copy protocol if inReplyTo or repost original …
4b0146c 
…wasn't copied there

once more with feeling!

for #1166
snarfed added a commit that referenced this issue Jul 10, 2024
@snarfed
Protocol.targets: only deliver reposts, replies etc if the original p…
714c317 
…ost was bridged

for #1166, #1151, maybe others. #1151 is the big motivation here: that we're currently generating and sending Bluesky a ton of reposts with blank subject cid/URL, which afaict is the main reason bridging is getting stuck for some accounts and the relay is constantly calling `getRepo`. I'm hoping this will reduce or eliminate that.

this isn't a big behavior change, but it is a kind of big change to routing logic. it's tested pretty well, but I still expect something to break. we'll see.
@snarfed
Copy link
Owner

snarfed commented Jul 10, 2024

714c317 is a beast, but it's looking promising. 🤞 Example reply that didn't get bridged because its in-reply-to post wasn't bridged: https://indieweb.social/@snarfed/112759737604412729

@snarfed
Copy link
Owner

snarfed commented Jul 10, 2024

Tentatively closing. Thanks again for reporting @TomCasavant, please reopen if you see any more of these!

@snarfed snarfed closed this as completed Jul 10, 2024
@snarfed snarfed mentioned this issue Jul 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
now
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snarfed @TomCasavant