Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quote tweet should not include h-cite content #723

Closed
gRegorLove opened this issue Jan 28, 2017 · 2 comments
Closed

Quote tweet should not include h-cite content #723

gRegorLove opened this issue Jan 28, 2017 · 2 comments
Labels
publish

Comments

@gRegorLove
Copy link

I switched up the markup a bit when attempting to publish a quote tweet: https://gregorlove.com/2017/01/i-joined-the-aclu-today/ The publish preview correctly indicated "will quote this tweet" (with link), but then the tweet preview text showed:

I joined the ACLU today and encourage you to donate. Send [@]sacca your receipt; he is matching up to $75K.

> We filed suit against…

When I published, the tweet text appeared exactly like that with no quoted tweet attached.

Bridgy Publish should probably drop the h-cite element that has u-quotation-of. There may be another issue of the quoted tweet not being attached.
@snarfed
Copy link
Owner

snarfed commented Jan 28, 2017

thanks for reporting!

@snarfed
Copy link
Owner

snarfed commented Jan 29, 2017

the second bug, dropping the quoted tweet URL, is because we append it to the content before we truncate.

that should be straightforward to fix. dropping the h-cite...not so much. :/

snarfed added a commit to snarfed/granary that referenced this issue Jan 31, 2017
@snarfed
microformats2: don't crash on raw string values for quotation-of
80d2a10 
for snarfed/bridgy#723

thanks for reporting @gRegorLove! this doesn't (yet) fix the whole bug, but it at least prevents the `'unicode' ... has no attribute 'get'` crash.
@snarfed snarfed mentioned this issue Feb 1, 2017
Closed
snarfed added a commit to snarfed/granary that referenced this issue Feb 1, 2017
@snarfed
add strip_quotations kwarg to Source._content_for_create()
bb0161a 
for creating quote tweets, snarfed/bridgy#723
snarfed added a commit to snarfed/granary that referenced this issue Feb 2, 2017
@snarfed
creating quote tweets: append tweet url *after* truncating
f36f061 
for snarfed/bridgy#723
@snarfed snarfed closed this as completed Feb 2, 2017
snarfed added a commit to snarfed/granary that referenced this issue Mar 16, 2017
@snarfed
microformats2: don't crash on raw string values for quotation-of
30ba5da 
for snarfed/bridgy#723

thanks for reporting @gRegorLove! this doesn't (yet) fix the whole bug, but it at least prevents the `'unicode' ... has no attribute 'get'` crash.
snarfed added a commit to snarfed/granary that referenced this issue Mar 16, 2017
@snarfed
add strip_quotations kwarg to Source._content_for_create()
2e10132 
for creating quote tweets, snarfed/bridgy#723
snarfed added a commit to snarfed/granary that referenced this issue Mar 16, 2017
@snarfed
creating quote tweets: append tweet url *after* truncating
cb83bcc 
for snarfed/bridgy#723
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
publish
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@snarfed @gRegorLove