Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get base object for Bluesky replies #673

Merged
merged 2 commits into from
Feb 4, 2024
Merged

Get base object for Bluesky replies #673

merged 2 commits into from
Feb 4, 2024

Conversation

JoelOtter
Copy link
Contributor

@snarfed
Copy link
Owner

snarfed commented Feb 4, 2024

This looks fine to me, happy to merge it once there's a test or two! Have you tested it locally though? Does it work?

@JoelOtter
Copy link
Contributor Author

Yep, working fine locally - will add some tests : )

@JoelOtter
Copy link
Contributor Author

@snarfed this sufficient? I couldn't really think what to add in terms of edge cases etc

@snarfed
Copy link
Owner

snarfed commented Feb 4, 2024

Perfect, thank you! Merging and deploying now...

@snarfed snarfed merged commit 701f7bb into snarfed:main Feb 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants