Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add permutation check in folding scheme #22

Merged
merged 6 commits into from
Oct 5, 2023
Merged

add permutation check in folding scheme #22

merged 6 commits into from
Oct 5, 2023

Conversation

chaosma
Copy link
Collaborator

@chaosma chaosma commented Oct 2, 2023 •
edited
Loading

This is for issue 21

@chaosma chaosma marked this pull request as draft October 2, 2023 04:44
@chaosma chaosma marked this pull request as ready for review October 3, 2023 11:08
@chaosma chaosma changed the title add folding support for halo2 copy constraint add permutation check in folding scheme Oct 3, 2023
@chaosma chaosma mentioned this pull request Oct 3, 2023
Closed
cyphersnake
cyphersnake requested changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@cyphersnake cyphersnake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will do the next review session in the morning as I need time to understand and fail the permutation job description and possibly improve it from a documentation perspective.

src/plonk/mod.rs Outdated Show resolved Hide resolved
src/plonk/mod.rs Outdated Show resolved Hide resolved
src/plonk/mod.rs Outdated Show resolved Hide resolved
src/plonk/mod.rs Show resolved Hide resolved
cyphersnake
cyphersnake approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@cyphersnake cyphersnake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic approved

src/plonk/mod.rs
for (left_col, vec) in self
.permutation
.as_ref()
.unwrap()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why in one place this is error, but here it's panic?

src/plonk/permutation.rs Outdated Show resolved Hide resolved
src/plonk/permutation.rs Show resolved Hide resolved
src/plonk/permutation.rs Show resolved Hide resolved
src/plonk/permutation.rs Outdated Show resolved Hide resolved
src/plonk/permutation.rs Show resolved Hide resolved
src/plonk/util.rs Outdated Show resolved Hide resolved
src/plonk/util.rs Show resolved Hide resolved
@chaosma chaosma merged commit 19df5d0 into main Oct 5, 2023
1 check passed
@chaosma chaosma deleted the permutation branch October 5, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyphersnake cyphersnake cyphersnake approved these changes

@drouyang drouyang Awaiting requested review from drouyang

Assignees

@chaosma chaosma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chaosma @cyphersnake