Add sha256 clear example #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaosma
approved these changes
Oct 9, 2023
chaosma
reviewed
Oct 9, 2023
| @@ -5,7 +5,7 @@ edition = "2021" | |||
|
|
|||
| [dependencies] | |||
| rand = "0.8" | |||
| halo2_proofs = { git = "https://github.com/snarkify/halo2", package="halo2_proofs", branch="snarkify/dev" } | |||
| halo2_proofs = { git = "https://github.com/snarkify/halo2", branch = "snarkify/dev" } | |||
There was a problem hiding this comment.
do we need add "package=halo2_proofs" here?
There was a problem hiding this comment.
It takes the pkg name from the beginning of the line, so specifying it is optional unless you want to change it in your project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just copied the sha256 gadget from halo2_gadget and made it build within our project as an example. I'll add this separately so that future changes I make will show up as a diff
Also fixed the clippy issue from the original codebase
Part of #12