#425 Use RedisDsn to build connection options for env based config #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR depends on #432 |
curry684
added
the
on-hold
|
Holding off on merge until Symfony 4.1.1 is out and therefore #432 can go in. |
|
CI looks good now :D |
|
Goodie 😆 |
|
Derp apparently I shouldn't have merged #432 first? |
curry684
removed
the
on-hold
|
@curry684 You did well. It was the right order. I'll fix the conflicts tomorrow ;-) |
fix snc#425 - Always use PredisParametersFactory to build connection options so that it creates consistency between env/non-env based config - Use RedisDsn to parse redis DSN instead of \Predis\Connection\Parameters::parse(). It creates consistence between phpredis and predis behavior.
|
@curry684 Done, it looks like it was a false positive conflict. Probably because I changed the commit sha1 of the based branch. |
|
Thanks! |
curry684
pushed a commit
that referenced
this pull request
Jul 19, 2018
fix #425 - Always use PredisParametersFactory to build connection options so that it creates consistency between env/non-env based config - Use RedisDsn to parse redis DSN instead of \Predis\Connection\Parameters::parse(). It creates consistence between phpredis and predis behavior. (cherry picked from commit 3f3c233)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #425