Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP/2: check window sizes, implement streaming #158

Merged
merged 8 commits into from
Dec 12, 2021
Merged

HTTP/2: check window sizes, implement streaming #158

merged 8 commits into from
Dec 12, 2021

Commits on Oct 29, 2021

  1. HTTP/2: check window sizes

    @the-mikedavis
    the-mikedavis committed Oct 29, 2021
    2 Configuration menu
    Copy the full SHA
    016d7ea View commit details
    Browse the repository at this point in the history

  2. document passing a stream body for HTTP/2

    @the-mikedavis
    the-mikedavis committed Oct 29, 2021
    Configuration menu
    Copy the full SHA
    3b11fcf View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2021

  1. use macro-form put_in/2 consistently

    @the-mikedavis
    the-mikedavis committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    2eae2ec View commit details
    Browse the repository at this point in the history

  2. only continue streaming when the connection is open for writing

    @the-mikedavis
    the-mikedavis committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    336e638 View commit details
    Browse the repository at this point in the history

  3. discard streaming requests when closed for writing

    @the-mikedavis
    the-mikedavis committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    c49ea5d View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2021

  1. fix off-by-one error in byte-fitting formula 

    testing against the exact connection-level window size, I see on
the last commit:

| bytes to send  | number of DATA frames | sizes of each frame |
|----------------|-----------------------|---------------------|
| 65_536         | 2                     | 65_536, 0           |
| 65_536 - 1     | 1                     | 65_535              |
| 65_536 + 1     | 3                     | 65_535, 2, 0        |
| 2 * 65_536     | 3                     | 65_535, 65_537, 0   |
| 2 * 65_536 - 1 | 3                     | 65_535, 65_536, 0   |
| 2 * 65_536 + 1 | 3                     | 65_535, 65_538, 0   |

this looks like the formula for how many bytes to fit when overloaded
is off-by-one.

after applying the change in this commit, the numbers work out
perfectly:

| bytes to send  | number of DATA frames | sizes of each frame |
|----------------|-----------------------|---------------------|
| 65_536         | 2                     | 65_536, 0           |
| 65_536 - 1     | 1                     | 65_535              |
| 65_536 + 1     | 3                     | 65_536, 1, 0        |
| 2 * 65_536     | 3                     | 65_536, 65_536, 0   |
| 2 * 65_536 - 1 | 3                     | 65_536, 65_535, 0   |
| 2 * 65_536 + 1 | 3                     | 65_536, 65_537, 0   |
    @the-mikedavis
    the-mikedavis committed Dec 5, 2021
    Configuration menu
    Copy the full SHA
    21d53d4 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2021

  1. combine Enum.filter/2 and Enum.reduce/3 calls

    @the-mikedavis
    the-mikedavis committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    11dd75e View commit details
    Browse the repository at this point in the history

  2. don't call IO.iodata_to_binary/1 on binary input

    @the-mikedavis
    the-mikedavis committed Dec 6, 2021
    Configuration menu
    Copy the full SHA
    466bf4b View commit details
    Browse the repository at this point in the history