Glitch 1 to implement 1 #31

schettn · 2020-05-18T11:11:53Z

Checklist:

Have you added an explanation of what your changes do and why you'd like them to be included?
Have you updated or added documentation for the change?
Have you tested your changes with successful results?

Type of Changes:

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

What is the current behavior? (link to any open issues here)

Currently there is no error handling for snek tasks. Snek sql tasks should have simple error handling #26
Currently cookie-utils is used to interact with cookies. The cookie-utils should be replaced with js-cookie #27
Currently the connection between a session and cookies is insufficient. The connection between token fields and the associated cookie should be improved #28
Currently Apollo does not include errors in responses. The Apollo Error Policy should be adjusted to improve error tracking #29
Currently the session begin is inconsistent. The session begin is inconsistent #30

What is the new behavior (if this is a feature change)?

Now there is simple error handling for snek tasks. Closes Snek sql tasks should have simple error handling #26
Now js-cookie is used to interact with cookies. Closes The cookie-utils should be replaced with js-cookie #27
Now the connection between a session and cookies is improved. Closes The connection between token fields and the associated cookie should be improved #28
Now Apollo does include error in responses. Closes The Apollo Error Policy should be adjusted to improve error tracking #29
Now the session begin is consistent. Closes The session begin is inconsistent #30

Other information:
As written in the coding guidelines snek-tonic, no more points are set at JSDoc headers. Exceptions include cases in which a comment spans several lines.

Over time, the intel should be adapted to the new coding guide line. #32 #33

Ref: https://github.com/js-cookie/js-cookie
Ref: https://www.apollographql.com/docs/angular/features/error-handling/
Ref: 🐍

Now it is possible to fetch DOM pages again. Because of the invalid header which was set, querying DOM was not possible.

The start of the session always returns the same object structure.

Cookie-utils has been replaced with js-cookie.

The alive checks and the refresh method have been updated.

Now a Apollo response can contain errors.

If a specific authentication related error occurs, steps are taken to maintain the session.

Documentation has been added to the new code parts.

The start of the session always returns the same object structure now. Even though the interfaces had been correctly adjusted before, the structure of the return value was not constant.

The file which contains the task error has been moved to a other location.

Aichnerc

Looks clean ⚽

src/session/index.ts

src/session/sessions.ts

src/templates/snek/gql/errors.ts

src/templates/snek/gql/tasks/auth.ts

src/templates/snek/gql/tasks/index.ts

pinterid

Looks good after some changes.

src/session/sessions.ts

pinterid

Looks good after a change.

@pinterid

The code quality has been improved due to a request of @pinterid.

kleberbaum

Should be ok to merge after a few changes.

src/session/index.ts

src/session/sessions.ts

pinterid

Looks good.

@kleberbaum

The code quality has been improved due to a request of @kleberbaum.

kleberbaum

Should be ok to merge.

schettn added 9 commits May 15, 2020 11:40

Adjust headers

2579742

Now it is possible to fetch DOM pages again. Because of the invalid header which was set, querying DOM was not possible.

Fix session begin inconsistency

e747b00

The start of the session always returns the same object structure.

Replace cookie utils

e3e7df9

Cookie-utils has been replaced with js-cookie.

Rework token alive checks

104ce28

The alive checks and the refresh method have been updated.

Modify Apollo errorPolicy

e820537

Now a Apollo response can contain errors.

Add error handling for snek tasks

010cdfb

If a specific authentication related error occurs, steps are taken to maintain the session.

Add documentation

262c5d2

Documentation has been added to the new code parts.

Fix session begin inconsistency part 2

1f8fd27

The start of the session always returns the same object structure now. Even though the interfaces had been correctly adjusted before, the structure of the return value was not constant.

Switch task error lcoation

fef8148

The file which contains the task error has been moved to a other location.

schettn added bug Something isn't working enhancement New feature or request invalid This doesn't seem right labels May 18, 2020

schettn requested review from Aichnerc, kleberbaum and pinterid May 18, 2020 11:11

schettn self-assigned this May 18, 2020

Aichnerc approved these changes May 18, 2020

View reviewed changes