Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hang after wrap around door open at croc? #1

Closed
dagit opened this issue Mar 7, 2023 · 10 comments
Closed

Hang after wrap around door open at croc? #1

dagit opened this issue Mar 7, 2023 · 10 comments

Comments

@dagit
Copy link

dagit commented Mar 7, 2023

I'm not sure what's needed to reproduce this. I was trying things out (seems like a cool project). I killed kraid. Got wave and speed. Then I went down to say hi to croc. I killed him then grabbed his etank. I then did the wrap around shot where you shoot off the right side of the screen and it opens the left side door. I heard the sound, so I assumed it worked. I paused the game to tell a friend. And when I focused the game again the music kept playing but it seemed to ignore all my inputs like it was frozen.

@dagit
Copy link
Author

dagit commented Mar 7, 2023

I tested this a bit more. The wrap around shot is not needed to reproduce this. Just fight croc until he takes a bath. Then pause the game (press start) after he starts moving to the left. The game will hang bring up the menu. The music will continue to loop but it will be unresponsive and fail to animate the map screen.

@dagit
Copy link
Author

dagit commented Mar 7, 2023

Another data point. I was in maridia, I wanted to take off gravity suit. I pressed start to pause the game and it hung.

@FitzRoyX
Copy link

FitzRoyX commented Mar 7, 2023

If you can provide savestates before these hangs it would help more. Shift+F1

@dagit
Copy link
Author

dagit commented Mar 7, 2023

Steps to reproduce:

  1. Download this save state: https://cdn.discordapp.com/attachments/968026725759975437/1082800400966619196/save0.sav
  2. Press F1 to load it
  3. Pause the game (press start)

It should hang at the map screen. The music will keep playing but you'll have to kill the process.

I got into that state by knocking croc into the water then grabbing his etank before he finishes melting. Then pausing after he starts moving to the left.

I'm having trouble reproducing the maridia one but that save was based on the croc state. So I wouldn't be surprised if fixing the issue at croc fixes the maridia hang too. As such, I'll hold off on trying to get a save state for that one.

I hope that helps.

@dagit
Copy link
Author

dagit commented Mar 8, 2023

I'm pretty sure that whatever is going on here the underlying issue is that it's trying to read the wrong memory for the map data. The reason I suspect this is because if I pause before croc jumps in the water my map looks like this:
image

and if I pause (and get the hang) my map looks like this:
image

In particular, look at business center (the room under norfair elevator). It's trying to draw stuff in the column left of that that shouldn't be on the map. I haven't been to the map room (or ice) and there is that weird circle next to the elevator.

@1lluminado
Copy link

save1.zip
Can verify that it will hang even with the weird circle.

@dAnthonyB
Copy link

From what I remember, in the vanilla game, if you get the etank while Croc's dying, the map won't fill in. I wonder if that's somehow related.

@dagit
Copy link
Author

dagit commented Mar 9, 2023

From what I remember, in the vanilla game, if you get the etank while Croc's dying, the map won't fill in. I wonder if that's somehow related.

That's a possibility, although I was able to reproduce it by staying on the ledge while croc dies. I guess next test would be to stay as far left as possible. I'm pretty sure the bad state happens during the croc melting animation. I noticed (by repeatedly pausing) that his texture gets messed up for a few frames.

@ScorelessPine
Copy link

Will second this issue, relating to the map information. I was playing through and tried to gravity jump in Maridia after visiting Crocomire, and the game froze (window unresponsive) while the music continued to play, while my map had these odd features off to the left side.
image

@dagit
Copy link
Author

dagit commented Mar 11, 2023

Thanks. This fixed it for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants