Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure header returns the same columns for all backends #239

Merged
merged 2 commits into from
Feb 3, 2021
Merged

fix: ensure header returns the same columns for all backends #239

merged 2 commits into from
Feb 3, 2021

Conversation

jorainer
Copy link
Collaborator

@jorainer jorainer commented Feb 2, 2021

@jorainer
fix: ensure header returns the same columns for all backends
f56e0c9 
- Fix for issue sneumann#238: ensure `header` returns the same columns for all backends.
@jorainer
Copy link
Collaborator Author

jorainer commented Feb 3, 2021

Note that the unit tests run without problems on my local installation (R 4.1 and BioC 3.13 devel).

@jorainer jorainer mentioned this pull request Feb 3, 2021
Open
@jorainer
Copy link
Collaborator Author

jorainer commented Feb 3, 2021

Thanks for the review @lgatto - but note that I can not merge - either you or @sneumann have to merge and submit to BioC.

@lgatto lgatto merged commit 373a390 into sneumann:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lgatto lgatto lgatto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorainer @lgatto