Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peak mz values when running findChromPeaks on XChromatograms object #765

Closed
CLUES-Emory opened this issue Sep 7, 2024 · 3 comments
Closed

Comments

@CLUES-Emory
Copy link

Hello,
Currently, mz values are dropped when running findChromPeaks on XChromatogram objects, even if the mz range for an XIC is included when defining the XChromatogram option. This is leading to some issues when we are detecting peaks and running correspondence analysis across multiple samples (we are creating XChromatograms from XICs generated in the rawrr package). Is there anyway to include the XChromatogram mz values (and/or the provided range) in the peak tables generated from XChromatograms objects? Thanks!

@CLUES-Emory
Copy link
Author

Ah, just realized the feature definitions return the row number of the chromatogram, which allowed me to link back to the original mz and resolves the issue above.

@jorainer
Copy link
Collaborator

thanks for reporting! Actually, this is a very interesting issue - indeed, reporting the m/z values in the chromPeaks() matrix if that information is provided/stored in the XChromatograms would be an interesting information.

jorainer added a commit that referenced this issue Sep 16, 2024
- Report also a chromatogram's m/z values if `findChromPeaks` is run on a
  `Chromatogram` or `Chromatograms` object (issue #765).
@jorainer
Copy link
Collaborator

btw, with the commit linked above I'm also reporting the chromatogram's m/z in the chromPeaks() matrix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants