Change rgl.* to *3d #654
Merged
Change rgl.* to *3d #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorainer
added a commit
that referenced
this pull request
Jan 16, 2023
- Fix problem with `fillChromPeaks` after `MatchedFilterParam` peak detection on very sparse data (i.e. data with many empty spectra).
|
Thanks @dmurdoch ! I will merge (and fix then the unit tests) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some upcoming changes to the rgl package will require changes to
xcms. I will be deprecating a number of rgl.* function
calls. You can read about the issues here:
I have made the required changes to xcms in the attached
patch file. These changes should work with both old and new rgl
versions, though some default colors and projections have changed.
Duncan Murdoch