Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guid comparisons are case sensitive. #5

Open
fabella opened this issue Nov 2, 2018 · 1 comment · May be fixed by #6
Open

Guid comparisons are case sensitive. #5

fabella opened this issue Nov 2, 2018 · 1 comment · May be fixed by #6

Comments

@fabella
Copy link

fabella commented Nov 2, 2018

The Equals is case sensitive. Can we make this case invariant?

it('test guid library', () => {
    const lowerCaseGuid: Guid = Guid.parse('00000001-0001-5365-7276-70726f496e63');
    const upperCaseGuid: Guid = Guid.parse('00000001-0001-5365-7276-70726F496E63');
 
    const areEqual = lowerCaseGuid.equals(upperCaseGuid);
 
    expect(areEqual).toBe(true);
});

The unit test above is failing.

@fabella fabella linked a pull request Nov 2, 2018 that will close this issue
gekkedev added a commit to ez-libs/ez-guid that referenced this issue Jul 4, 2019
@brou0039
Copy link

Please complete this, it is quite useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants