Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unrecognized Casanovo result.mztab file line start code #242

Closed
Ln9052 opened this issue Nov 27, 2023 · 16 comments
Closed

Unrecognized Casanovo result.mztab file line start code #242

Ln9052 opened this issue Nov 27, 2023 · 16 comments

Comments

@Ln9052
Copy link

Ln9052 commented Nov 27, 2023

Hi Schulte, currently, I've encountered an issue when using Stitch to read "result.mztab" file from Casanovo. The error message reads, for example,
image
However, I have verified the beginning lines of the "result.mztab" file and ensured that they start with valid codes.
image
What steps should I take to resolve this issue?Do you have any helpful suggestions?
Thank you.

@douweschulte
Copy link
Member

That is indeed looking quite weird. Could you send me the full file? Either as attachment here in the issue or to my email (d.schulte(AT)uu.nl)? That way I will be able to check what is wrong on my side.

@Ln9052
Copy link
Author

Ln9052 commented Nov 27, 2023 via email

@douweschulte
Copy link
Member

I am afraid attaching files in this way does not work could you try sending it to me directly or adding it to this issue via the webinterface of github?

@Ln9052
Copy link
Author

Ln9052 commented Nov 27, 2023

Thank you for the reminder; I'm feeling troubled. I've noticed that attaching a ".mztab" format file on the GitHub web page is restricted. It seems that GitHub web pages don't support the upload of ".mztab "format files. I'll figure out an alternative way to share the file with you.

@Ln9052
Copy link
Author

Ln9052 commented Nov 27, 2023

image

@douweschulte
Copy link
Member

It seems to support gzipped files (.zip/.gz) so you could try to zip it first.

@Ln9052
Copy link
Author

Ln9052 commented Nov 27, 2023

Great! Thanks! Please take a look at this (.zip) filesample_preprocessed_spectra.zip

@douweschulte
Copy link
Member

Thanks I will take a look at it!

douweschulte added a commit that referenced this issue Nov 27, 2023
@douweschulte
Copy link
Member

I did not get the same error. But the file contained many empty lines, for which I found a way to generate this output which I hope to have built a fix for. I additionally found that this file contains charge with a decimal point (2.0 instead of 2) which would give an error as well. Both are fixed and the nightly build based on the commit I just made has these fixes applied. If this new version does not work for you let me know and I will take another look.
Note: the automated build pipeline takes about 1 hour for all benchmarking to finish, only after that time will the nightly binaries be available.

@Ln9052
Copy link
Author

Ln9052 commented Nov 27, 2023

Thank you very much. I will carefully review your comments and make adjustments based on the actual experience of running the nightly version of Stitch. Thanks again.

@Ln9052
Copy link
Author

Ln9052 commented Nov 28, 2023

Hi Schulte, I found that this nightly version #372 Small mztab issues for #242 #372 did not work for me. This is my batchfile.
monoclonal_try_casanovo.txt
And this is the error information. Thanks.
image

@douweschulte
Copy link
Member

The trouble is that the file has a lot of weird newlines ('enters') and these break while reading them in. My test computer runs linux , and there it works, but this stuff works differently on windows. I will try to make a fix in the code itself, but you could also, if you feel comfortable, change the file to not contain these newlines. For this open the file in a text editor, copy the empty line you see there and replace this (control+H in most programs) with nothing. That should make the file run immediately without having to wait for my fix.

@douweschulte
Copy link
Member

With some further inspection I see that your file uses \r\r\n as newline pattern, which is extremely weird. What kind of system did you run Casanovo on? This pattern does not work well with the code I wrote to always detect the newline pattern for any file, as this is not a sensible newline pattern. I attached the file where I replaced \r\r\n with \r\n which is the normal newline pattern on windows. This file should work. If there are any more problems feel free to let me know.
sample_preprocessed_spectra_normalised.zip

@Ln9052
Copy link
Author

Ln9052 commented Nov 28, 2023

Thank you very much. I am running casanovo on a Windows system, and its result file contains many empty lines. I will attempt to use the file you sent to see if stitch can read it, compare the differences between the two files, and try to identify the reasons for their differences.

@douweschulte
Copy link
Member

If you are running Casanovo from windows that could be the reason why it is so weird, then maybe an issue should be raised in Casanovo itself, so they can fix their output.

@Ln9052
Copy link
Author

Ln9052 commented Nov 28, 2023

I have just used the file you provided, and it ran successfully. Thank you for your advice and suggestions. The issue may lie in Casanovo's output.Thank you very much for your assistance.

@snijderlab snijderlab deleted a comment from wenjinwu1985 Apr 26, 2024
@snijderlab snijderlab deleted a comment from wenjinwu1985 Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants