Skip to content

Login form not working with Firefox password manager #13365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks done
jpdigital opened this issue Jul 26, 2023 · 3 comments
Closed
2 tasks done

Login form not working with Firefox password manager #13365

jpdigital opened this issue Jul 26, 2023 · 3 comments
Assignees

Comments

@jpdigital
Copy link

Debug mode

Describe the bug

Firefox does not recognize the user field, and does enter the stored use name.

Firefox Mobile is not able to insert the stored password into the password field.

This is a BIG usuability issue for us. Please use standard input fields so that the browser's passord managers can recongnize the input fieldsd and work as intended.

Reproduction steps

  1. Store the credentials for Snipe IT in the password manager of Firefox
  2. Log out
  3. Try to log in. Firefox does not suggest credentials when entering the cursor into the user field, only after entering the username and moving to the password field. On Firefox mobile, after selecting the correct account, the password is not inserted into the password field.

Expected behavior

In step 3: The username and password fields are automatically filled out by Firefox if Firefox has stored credentials for the Snipe IT instance.

Screenshots

No response

Snipe-IT Version

6.1.2

Operating System

Linux (Debian)

Web Server

Apache

PHP Version

7.4.33

Operating System

Arch Linux

Browser

Firefox

Version

115

Device

Xiomi

Operating System

Android

Browser

Firefox

Version

115

Error messages

none

Additional context

No response

@welcome
Copy link

welcome bot commented Jul 26, 2023

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@marcusmoore
Copy link
Collaborator

Ah that is frustrating. I'll take a look and see if we can improve this.

@marcusmoore marcusmoore self-assigned this Jul 26, 2023
@snipe
Copy link
Member

snipe commented Aug 15, 2023

We are already using standard login elements.

<div class="form-group">
    <label for="username"><i class="fas fa-user" aria-hidden="true"></i> Username</label>
    <input class="form-control" placeholder="Username" name="username" type="text" id="username" autocomplete="off" autofocus>
    
</div>
<div class="form-group">
    <label for="password"><i class="fa fa-key" aria-hidden="true"></i> Password</label>
    <input class="form-control" placeholder="Password" name="password" type="password" id="password" autocomplete="off">
    
</div>
<div class="form-group">
    <label class="form-control">
        <input name="remember" type="checkbox" value="1"> Remember Me
    </label>
</div>

I suppose we could remove the autocomplete="off" aspect, but we had added that for security reasons way back when (and many browsers don't respect it anyway.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants