Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #11509 allow-ldap-anonymous-bind #11510

Merged
merged 2 commits into from
Aug 22, 2022
Merged

Conversation

sunflowerbofh
Copy link
Contributor

Description

Our ldap server can only be queried with anonymous bind. Therefore we need that feature. After merging you needn't fill the LDAP Bind Username + LDAP Bind Password field if not wanted.

Type of change

Please delete options that are not relevant.

  • [ x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Replaced app/Modles/Ldap.php. Tried with anonymous and password-based bind. Did ldap test sync and user test login. Read log files and debugging output.

Test Configuration:

  • PHP version: php8.1
  • MySQL version: mariadb-server 1:10.6.8-1
  • Webserver version: apache2 2.4.54-2
  • OS version: Debian bullseye

Checklist:

  • [ x] I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
  • [x ] I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • [.] New and existing unit tests pass locally with my changes
    (unit tests errors refer to missing database.sqlite and have nothing to do with the change)

@welcome
Copy link

welcome bot commented Jul 15, 2022

💖 Thanks for this pull request! 💖

We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already.

Examples of commit messages with semantic prefixes:

  • Fixed #<issue number>: don't overwrite prevent_default if default wasn't prevented
  • Added #<issue number>: add checkout functionality to assets
  • Improved Asset Checkout: use new notification method for checkout

Things that will help get your PR across the finish line:

  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@sunflowerbofh sunflowerbofh changed the title allow-ldap-anonymous-bind Fixed #11509 allow-ldap-anonymous-bind Jul 15, 2022
Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I get this rebased or, maybe, cherry-picked, so it just includes the appropriate changes? When I can get this just as the main piece from app/Models/Ldap.php, I think we would be able to take it.

…nonymous ldap applied).

Signed-off-by: Katharina Drexel <katharina.drexel@bfh.ch>
@welcome
Copy link

welcome bot commented Aug 22, 2022

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants