Adds ability to mass email all assigned list to #11821

Godmartinz · 2022-09-14T16:56:09Z

Description

Adds the ability to send all users a list of their devices.

There are a lot of buttons in the picture above. Open to placing the button in another suggested place.

Fixes # sc-19519 fd-30564

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
[ X] New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test A
Test B

Test Configuration:

PHP version:
MySQL version
Webserver version
OS version

Checklist:

I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

snipe · 2022-09-14T17:19:19Z

Is this email I just got from your testing?

Godmartinz · 2022-09-14T17:22:02Z

Ah yes it is, I re-seeded my db so your email is back in there. I will remove that now. (also you have no assets assigned to you on my local 😄 )

snipe · 2022-09-14T17:27:14Z

All good :) Just that if nothing is assigned to a user, they probably shouldn't get an email, right?

snipe

We should probably not send emails to users who do not have anything assigned to them.

app/Http/Controllers/Users/UsersController.php

Signed-off-by: snipe <snipe@snipe.net> (cherry picked from commit 7c21158)

…l-assigned-list-to

Godmartinz · 2023-01-05T18:24:44Z

Emailing users only if they have assets has been implemented. we just have a crappy Ux placement for right now 🙁

okkhalid · 2023-01-29T02:48:37Z

Hi, is this script will be added to the new version? also can we select specific people to send the assets?

MajorBlackbird · 2023-02-03T14:04:22Z

Hey,

firstly thanks for your guys work you put into this. :)
Couldnt you, at least for now, add it as a point in the dropdown menu on the "People" page?

snipe · 2023-02-04T00:22:30Z

That would only imply it only affects the visible users on that page (since everything else in that menu does that), which isn't what that functionality does.

snipe · 2023-02-04T00:26:10Z

app/Models/Accessory.php

@@ -254,7 +254,7 @@ public function getImageUrl()
     */
    public function users()
    {
-        return $this->belongsToMany(\App\Models\User::class, 'accessories_users', 'accessory_id', 'assigned_to')->withPivot('id', 'created_at', 'note')->withTrashed();
+        return $this->belongsToMany(\App\Models\User::class, 'accessories_users', 'accessory_id', 'assigned_to')->withPivot('id', 'created_at' , 'note')->withTrashed();


Not sure why this extra space was put in here?

snipe · 2023-02-04T00:27:11Z

app/Http/Controllers/Users/BulkUsersController.php

@@ -249,4 +251,38 @@ protected function logItemCheckinAndDelete($items, $itemType)
            $logAction->logaction('checkin from');
        }
    }
+    protected function findAssetOwners()


I don't think this method is needed here. We have existing methods on the model that we can likely use instead of duplicating code here, esp since this method is only used once.

snipe · 2023-02-04T00:28:43Z

app/Http/Controllers/Users/BulkUsersController.php

@@ -249,4 +251,38 @@ protected function logItemCheckinAndDelete($items, $itemType)
            $logAction->logaction('checkin from');
        }
    }
+    protected function findAssetOwners()
+    {
+        $asset_owners= Asset::all()->where('assigned_to', '!=', null)->pluck('assigned_to')->toArray();


This call as it is now would erroneously include the ids of users when it shouldn't, for example if an asset is checked out to a location.

snipe · 2023-02-04T00:29:53Z

@MajorBlackbird until this gets added into the GUI, you can use this cli command to accomplish what this PR does: https://snipe-it.readme.io/docs/user-inventory

Snipe-IT Documentation
User Inventory
Snipe-IT offers an optional command line utility for sending out emails to your users that have items checked out to them, to remind them of what has been issued to them. This can be useful if your auditing process is a little more information, and you ask your users to self-report whether or not al...

MajorBlackbird · 2023-02-06T10:37:58Z

@MajorBlackbird until this gets added into the GUI, you can use this cli command to accomplish what this PR does: https://snipe-it.readme.io/docs/user-inventory

Snipe-IT Documentation**User Inventory**Snipe-IT offers an optional command line utility for sending out emails to your users that have items checked out to them, to remind them of what has been issued to them. This can be useful if your auditing process is a little more information, and you ask your users to self-report whether or not al...

Wow thank you very much and sorry for missing that in the documentation!

Snipe-IT Documentation
User Inventory
Snipe-IT offers an optional command line utility for sending out emails to your users that have items checked out to them, to remind them of what has been issued to them. This can be useful if your auditing process is a little more information, and you ask your users to self-report whether or not al...

shortcut-integration · 2023-05-10T06:38:37Z

This pull request has been linked to Shortcut Story #19519: Ability to mass email "All Assigned" list to each user.

snipe · 2023-05-10T06:38:52Z

Closing this for housekeeping for now - we can discuss and possibly re-open later

Godmartinz added 3 commits September 12, 2022 12:43

route, button, method created

c6db7ad

updated comment

10ec24c

completes db query correctly

0a0cb49

Godmartinz requested a review from snipe as a code owner September 14, 2022 16:56

probot-autolabeler bot added backend frontend labels Sep 14, 2022

snipe requested changes Sep 15, 2022

View reviewed changes

app/Http/Controllers/Users/UsersController.php Outdated Show resolved Hide resolved

figuring out the model functions needed

87a1af9

Godmartinz force-pushed the feature/sc-19519/ability-to-mass-email-all-assigned-list-to branch from 260b4dc to 87a1af9 Compare October 4, 2022 17:22

probot-autolabeler bot added the skins label Oct 4, 2022

Godmartinz added 7 commits October 6, 2022 10:29

updated pivot, still not working

09f077a

swing and a miss. still working on query

fbf9420

correctly queries Accessory users

ec56fb5

emails all users with assets, licenses, accessories

168615d

removes dead code and space

5f7a638

removes dead code

b65fd46

removes dead code

1693204

Godmartinz requested a review from snipe October 18, 2022 18:03

snipe and others added 2 commits November 8, 2022 16:01

Bumped version

4173dec

Signed-off-by: snipe <snipe@snipe.net> (cherry picked from commit 7c21158)

adds a dropdown menu on user index, format sucks rn

7ec45e8

snipe mentioned this pull request Jan 5, 2023

[Feature Request]: sending summary of devices list under user to email for audit #12309

Open

snipe removed the skins label Jan 5, 2023

Merge branch 'develop' into feature/sc-19519/ability-to-mass-email-al…

9e9f92b

…l-assigned-list-to

probot-autolabeler bot added the skins label Jan 5, 2023

snipe reviewed Feb 4, 2023

View reviewed changes

snipe closed this May 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adds ability to mass email all assigned list to #11821

Adds ability to mass email all assigned list to #11821

Godmartinz commented Sep 14, 2022

snipe commented Sep 14, 2022

Godmartinz commented Sep 14, 2022

snipe commented Sep 14, 2022

snipe left a comment

Godmartinz commented Jan 5, 2023

okkhalid commented Jan 29, 2023

MajorBlackbird commented Feb 3, 2023

snipe commented Feb 4, 2023 •

edited

Loading

snipe Feb 4, 2023

snipe Feb 4, 2023

snipe Feb 4, 2023

snipe commented Feb 4, 2023 •

edited by unfurl-links bot

Loading

MajorBlackbird commented Feb 6, 2023 •

edited by unfurl-links bot

Loading

shortcut-integration bot commented May 10, 2023

snipe commented May 10, 2023

Adds ability to mass email all assigned list to #11821

Adds ability to mass email all assigned list to #11821

Conversation

Godmartinz commented Sep 14, 2022

Description

Type of change

How Has This Been Tested?

Checklist:

snipe commented Sep 14, 2022

Godmartinz commented Sep 14, 2022

snipe commented Sep 14, 2022

snipe left a comment

Choose a reason for hiding this comment

Godmartinz commented Jan 5, 2023

okkhalid commented Jan 29, 2023

MajorBlackbird commented Feb 3, 2023

snipe commented Feb 4, 2023 • edited Loading

snipe Feb 4, 2023

Choose a reason for hiding this comment

snipe Feb 4, 2023

Choose a reason for hiding this comment

snipe Feb 4, 2023

Choose a reason for hiding this comment

snipe commented Feb 4, 2023 • edited by unfurl-links bot Loading

MajorBlackbird commented Feb 6, 2023 • edited by unfurl-links bot Loading

shortcut-integration bot commented May 10, 2023

snipe commented May 10, 2023

snipe commented Feb 4, 2023 •

edited

Loading

snipe commented Feb 4, 2023 •

edited by unfurl-links bot

Loading

MajorBlackbird commented Feb 6, 2023 •

edited by unfurl-links bot

Loading