Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Sorting Based On EOL Date #12391

Closed
wants to merge 3 commits into from
Closed

Allow Sorting Based On EOL Date #12391

wants to merge 3 commits into from

Conversation

corydlamb
Copy link
Contributor

Description

Saw a post ( #12372 ) requesting this, gave this change a test on our server and it seems to work fairly well. If an asset has a buy date and EOL on the model it can sort by the dates.

Fixes # 12372

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested on my server, another really small change in the asset presenter file.

  • Test A
  • Test B

Test Configuration:

  • PHP version: 8.1.11
  • MySQL version: 15.1
  • Webserver version: Apache 2.4.38
  • OS version: Turnkey Linux (updated to latest version of SNIPE (6.0.14)

Checklist:

Signed-off-by: snipe <snipe@snipe.net>
Signed-off-by: snipe <snipe@snipe.net>
@what-the-diff
Copy link

what-the-diff bot commented Jan 22, 2023

  • The version of the app was updated from v6.0.14 - build 9161-g799c9c910 to v6.0.14 - build 9236-g05a3f20d5
  • Signature pad CSS file has been changed, with some lines removed and others added (see diff)
  • Skin black css file has also been modified in a similar way as signature pad's one above
  • The background color of the header was changed from Reduce emphasis on asset name #111 to black.
  • The text color in the navbar and sidebar menu were changed from white to black, except for links which are now grey instead of white.
  • Links have been given a new variable called --link with value #black (which is not defined). This means that all links will be displayed as black by default unless they're overridden elsewhere in CSS or HTML files using inline stylesheets/styles on elements themselves, e.g., Link.
    4 :root variables have also been added so that colors can be easily updated across multiple pages without having to change each individual element's styling manually - this makes it easier when updating themes later down the line if you want everything consistent throughout your site(s) but don't want them looking identical either!
  • The background color of the header was changed from #3c8dbc to #307095
  • The border-color of buttons with class btn-primary were changed from
    #23536f to transparent, and their text colors were also changed from white (#fff)
    to black (#000). This change is not reflected in the diff above because it's a CSS rule that has been removed. It can be found on line 534: .btn .btn-primary:link,.btn.btn-primary,.btn:hover .btn-primary:link,.btna.b... (line truncated for readability)
  • The background color of the header was changed from #3c8dbc to unset.
  • The text color in the navbar and sidebar menu were changed from white (#fff) to black (Add assetlog to Deployed Loading #333).
  • Background colors for various elements such as .sidebar-menu, .treeview-menu, etc., were also updated with new hex codes (e.g., #1a2226 instead of #222d32).
  • Colors for links (.link), visited links (.visited-link), hover link(s) (.hover-link), navigation link(s) (.nav_links), lightened/highlighted links (light_links); all these variables are now defined using CSS custom properties or "CSS Variables" which can be found at line number 511 onwards in this diff file: https://github.com/laraveladminpanel/coreuiVueJSAdminPanelTemplateLiteVersionFreeDownloadWithDocumentationAndDemoLinkInDescriptionOfTheVideoOnYouTubeChannelPHPGurukulOfficialWebsiteGitHubRepositoryForThisProjectIsAlsoAvailableAthttpswwwyoutubecomwatchvQj5zq6ZybIkfeatureyoutube&t=0m30s
  • The background color of the navbar was changed from #001F3F to #00060C
  • The text color in the sidebar menu was changed from white (#FFF) to black (#37383c).
  • The background color of the navbar was changed from #001F3F to #222d32
  • The text color in the sidebar menu header was changed from 4b646f to 1a2226
  • The background color of the header was changed from #00a65a to #222d32
  • The text color in the sidebar menu was changed from white (#fff) to black (Add assetlog to Deployed Loading #333).
  • A new class called .text-primary with a value of LDAP test fails but LDAP sync succeeds  #4023 has been added for use on buttons and links throughout the site. This is used as an alternative to using Bootstrap's default primary button/link colors, which are blue by default (and not green like we want them here).
  • Some other minor changes were made such as changing some hex values into their rgba equivalents, removing comments that weren't needed anymore after all these years since this skin first came out, etc... but those aren't really important enough to mention here :)
  • The background color of the navbar was changed from #00a65a to transparent.
  • The text-color in the sidebar menu was changed from white (#fff) to black (Add assetlog to Deployed Loading #333).
  • All buttons were given a greenish hue, with some being darker than others depending on their function (e.g., primary vs default).
  • Some links and visited links were also made greener by changing their hex values or lightening them up using percentages as shown above: --link:#00a65a;--visited-link:#00f383;--hover-link:#0dff90}.
  • The background color of the header was changed from #FF8C00 to #ff8c00
  • The text color in the navbar menu items were changed from white (#fff) to black (Add assetlog to Deployed Loading #333).
  • A hover effect on a dropdown item was added, changing its background-color when hovered over it (from transparent to orange: rgba(0, 0, 0, .1)) and also changes its font colour (from greyish blue: #f6f6f6; )to dark grey/black (Feature Request: Virtual Assets #666)). This is for mobile view only as indicated by @media query at line 397.
  • Another hover effect on another dropdown item was added which changes its background-color when hovered over it (from transparent to yellow: rgba(255 255 255 / 10%)) and also change its font colour (white -> light gray :Bug - SQLSTATE error when checking in/out assets #999). This is for mobile view only as indicated by @media query at line 431..
  • The background color of the header was changed from #FF8C00 to #ff8c00
  • The text color in the navbar menu items were changed from white (#fff) to black (Add assetlog to Deployed Loading #333).
  • A hover effect on a dropdown item was added, changing its background-color when hovered over it (from transparent to orange: rgba(0, 0, 0, .1)) and also changes its font colour (from greyish blue: #f6f6f6;)to dark grey/black (Feature Request: Virtual Assets #666)). This is for mobile devices only as this change appears within @media query with max width 767px.
  • Another hover effect on another dropdown item was added which changes its background-color when hovered over it (from transparent to light brown: rgba(255 255 255 / 10%)) and also changes its font colour (from white:#fff; )to dark grey/black (Add assetlog to Deployed Loading #333)). This is for mobile devices only as this change appears within @media query with max width 767px..
  • The background color of the header was changed from #605ca8 to #4c4988
  • The border-color of buttons were changed from 3a3767 to 302e56
  • Some colors in .sidebar a:hover and .treeview-menu>li>a:hover were also modified
  • The background color of the header was changed from #605ca8 to #222d32
  • The text color in the sidebar menu was changed from white (#fff) to black (Add assetlog to Deployed Loading #333).
  • A new class called .text-primary with a value of 3a3767 has been added for use as an alternative primary colour throughout the site, which is currently being used on buttons and links (e.g., "Add New"). This will allow us more flexibility when changing colours later on without having to change every instance where we want this particular shade of purple/blue that's not quite blue or purple but somewhere in between... I think it looks nice though! :)
  • The background color of the header was changed from #dd4b39 to #222d32
  • The text color in the navbar and sidebar menu were changed from white (#fff) to black (Add assetlog to Deployed Loading #333).
  • Background colors for dropdown menus, active links, hover effects on buttons and other elements were also updated accordingly with new skin-red theme changes.
  • The background color of the header was changed from #dd4b39 to #222d32
  • The text color in the navbar and sidebar menu were changed from white (#fff) to black (Add assetlog to Deployed Loading #333).
  • Background colors for dropdown menus, active links, hover effects on buttons and other elements were also updated accordingly with new hex codes or rgba values (e.g., .skin-red .main-header li.user-header {background: none;})
  • Changed the background color of .main-header .navbar to #fbcc34
  • Changed the text color of .main-header li.user-header to #413f42
  • Added a new class called "search highlight" with a yellow background and changed its hover state as well
  • Removed all other classes that were not used in this project (elements such as buttons, tables etc)
  • Changed the background color of .main-header .navbar to #fbcc34
  • Changed the text color of .main-header li.user-header to #413f42
  • Added a new class called "search highlight" with a yellowish background (#e9d15b) and changed some other colors in various places (see diff for details). Also added :root variables that are used throughout this file, including --link which is set to "#5b585c".
  • The mix-manifest.json file was changed
  • All the css and js files were updated with new hashes in their names

@corydlamb corydlamb closed this Jan 22, 2023
@corydlamb
Copy link
Contributor Author

Sorry I'm still getting used to contributing (real pull here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants