-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added EULAs in print user's assets #14769
Conversation
PR Summary:
|
Thanks for this! I think we'd need to either make this a setting or at least make it be show/hideable in the print view. For folks who have a lot of assets with different EULAs, that could start to eat up a LOT of printer pages. |
@snipe I agree, I will try to add the show/hide option |
@@ -352,25 +359,44 @@ class="snipe-table table table-striped inventory" | |||
</table> | |||
@endif | |||
|
|||
<p></p> | |||
<div class="pull-right"> | |||
<button class="btn btn-default" type="button" data-toggle="collapse" data-target="#eula-row" aria-expanded="false" aria-controls="eula-row" title="EULAs"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this button show up on the print version?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@snipe I was in doubt if hide or not but I have seen that the other 2 buttons in the page are printable, so I didn't use a different behavior, but I prefer to hide them. So if you agree I hide all 3 buttons with the property hidden-print
@snipe I've hidden the button from print. I didn't change the other 2 buttons because they are in the bootstrap table and I suppose that changing them means changing in all application and I don't know if it is what you desire |
@snipe let me know if there is something else to fix, thanks |
Added EULAs when we want to print all assets assigned to a users and ask him/her to sign.
Description
When we assign assets to a user after on-boarding we deliver a sheet with all his/her assets and ask to sign for confirmation. But there are no EULAs on it, so I added them for each category of asset provided. Hope this can be useful for all users.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: