Add async support #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds support for working with the august api with async The existing non-async support is left in-tact and it now shares a common base module for Api and Authenticator to ensure backwards compat. When using async, the following changes need to be made in your code Api is now ApiAsync ApiAsync must be passed an aiohttp ClientSession() as the first argument await async_setup() must be called to setup the object after creating it Authenticator is now AuthenticatorAsync AuthenticatorAsync must be passed an aiohttp ClientSession() as the first argument await async_setup_authentication() must be called to setup the object AugustApiHTTPError is replaced with AugustApiAIOHTTPError Checking for RequestException is replaced with checking for ClientError All of the async functions are prefixed with async_ Ex get_operable_locks is now async_get_operable_locks
|
Awesome work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for working with the august api with async
The existing non-async support is left in-tact and it now shares
a common base module for Api and Authenticator to ensure
backwards compat.
When using async, the following changes need to be made in your
code
Api is now ApiAsync
ApiAsync must be passed an aiohttp ClientSession()
as the first argument
await async_setup() must be called to setup the object
after creating it
Authenticator is now AuthenticatorAsync
AuthenticatorAsync must be passed an aiohttp ClientSession()
as the first argument
await async_setup_authentication() must be called to setup
the object
AugustApiHTTPError is replaced with AugustApiAIOHTTPError
Checking for RequestException is replaced with checking for
ClientError
All of the async functions are prefixed with async_
Ex get_operable_locks is now async_get_operable_locks