Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make conventions uniform across tutorials #70

Merged
merged 4 commits into from
Aug 14, 2019
Merged

Make conventions uniform across tutorials #70

merged 4 commits into from
Aug 14, 2019

Conversation

brahmaneya
Copy link
Collaborator

Test Plan
tox passes

@vincentschen
Copy link
Member

This is awesome! Sadly, looks like a bunch of stuff changed from underneath before we could merge this — maybe a rebase and then another pass would help?

Copy link
Member

@vincentschen vincentschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expect there to be some related changes in the slicing tutorial related to naming (features, pred_test, etc.) — let's do a quick pass there?

crowdsourcing/crowdsourcing_tutorial.py Outdated Show resolved Hide resolved
recsys/recsys_tutorial.py Outdated Show resolved Hide resolved
@brahmaneya
Copy link
Collaborator Author

I'd expect there to be some related changes in the slicing tutorial related to naming (features, pred_test, etc.) — let's do a quick pass there?

There are no changes there because I've changed other things to be compatible with it (features / vectors ->X_, Y_preds -> preds).

Copy link
Member

@vincentschen vincentschen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from snorkel.utils import preds_to_probs

preds_test = sklearn_model.predict(X_test)
probs_test = preds_to_probs(preds_test, 2)

I see this line in the tutorial — but I think that's it! Otherwise, LGTM

@brahmaneya brahmaneya merged commit 3476da0 into master Aug 14, 2019
@brahmaneya brahmaneya deleted the conventions branch August 14, 2019 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants