-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make conventions uniform across tutorials #70
Conversation
48504c3
to
8bdd017
Compare
8bdd017
to
acc20c7
Compare
This is awesome! Sadly, looks like a bunch of stuff changed from underneath before we could merge this — maybe a rebase and then another pass would help? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd expect there to be some related changes in the slicing tutorial related to naming (features, pred_test, etc.) — let's do a quick pass there?
There are no changes there because I've changed other things to be compatible with it (features / vectors ->X_, Y_preds -> preds). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from snorkel.utils import preds_to_probs
preds_test = sklearn_model.predict(X_test)
probs_test = preds_to_probs(preds_test, 2)
I see this line in the tutorial — but I think that's it! Otherwise, LGTM
Test Plan
tox passes