Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-833537 Separate JWT client #841

Merged
merged 1 commit into from
Jul 10, 2023
Merged

SNOW-833537 Separate JWT client #841

merged 1 commit into from
Jul 10, 2023
+167 −39

Conversation

sfc-gh-pfus
Copy link
Collaborator

@sfc-gh-pfus sfc-gh-pfus commented Jul 5, 2023 •
edited
Loading

Description

Please explain the changes you made here.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pfus sfc-gh-pfus force-pushed the SNOW-833537-jwt-client branch 2 times, most recently from 1d3bc12 to 096ef73 Compare July 5, 2023 13:00
@sfc-gh-pfus sfc-gh-pfus marked this pull request as ready for review July 6, 2023 05:32
@sfc-gh-pfus sfc-gh-pfus requested a review from a team as a code owner July 6, 2023 05:32
ghost
ghost approved these changes Jul 6, 2023
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sfc-gh-igarish
sfc-gh-igarish approved these changes Jul 8, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pfus sfc-gh-pfus merged commit b81442e into master Jul 10, 2023
@sfc-gh-pfus sfc-gh-pfus deleted the SNOW-833537-jwt-client branch July 10, 2023 05:42
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz left review comments

@sfc-gh-dheyman-1 sfc-gh-dheyman-1 sfc-gh-dheyman-1 left review comments

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

@sfc-gh-ext-simba-lb sfc-gh-ext-simba-lb Awaiting requested review from sfc-gh-ext-simba-lb

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl Awaiting requested review from sfc-gh-ext-simba-jl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sfc-gh-pfus @sfc-gh-igarish @sfc-gh-dprzybysz @sfc-gh-pbulawa @sfc-gh-dheyman-1