Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-856850: Add missing parameter check in tests #842

Merged
merged 1 commit into from
Jul 7, 2023
Merged

SNOW-856850: Add missing parameter check in tests #842

merged 1 commit into from
Jul 7, 2023

Conversation

sfc-gh-pbulawa
Copy link
Collaborator

Description

Add missing parameter ExternalBrowserTimeout check in tests.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-pbulawa sfc-gh-pbulawa requested a review from a team as a code owner July 6, 2023 11:13
sfc-gh-igarish
sfc-gh-igarish approved these changes Jul 6, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-pbulawa sfc-gh-pbulawa merged commit 7c49c89 into master Jul 7, 2023
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the fix_missing_check branch July 7, 2023 06:24
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

@sfc-gh-dprzybysz sfc-gh-dprzybysz sfc-gh-dprzybysz approved these changes

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

@sfc-gh-dheyman-1 sfc-gh-dheyman-1 Awaiting requested review from sfc-gh-dheyman-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sfc-gh-pbulawa @sfc-gh-igarish @sfc-gh-dprzybysz @sfc-gh-pfus