Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SNOW-892549] Remove references to sfcdev1 #885

Merged
merged 2 commits into from
Aug 18, 2023
Merged

[SNOW-892549] Remove references to sfcdev1 #885

merged 2 commits into from
Aug 18, 2023

Conversation

sfc-gh-skumbham
Copy link
Contributor

Description

Please explain the changes you made here.

Checklist

  • Code compiles correctly
  • Run make fmt to fix inconsistent formats
  • Run make lint to get lint errors and fix all of them
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary

@sfc-gh-skumbham sfc-gh-skumbham requested a review from a team as a code owner August 16, 2023 23:51
sfc-gh-igarish
sfc-gh-igarish approved these changes Aug 16, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-skumbham sfc-gh-skumbham merged commit 06f0b45 into master Aug 18, 2023
21 checks passed
@sfc-gh-skumbham sfc-gh-skumbham deleted the skumbham-SNOW-892549 branch August 18, 2023 17:59
@github-actions github-actions bot locked and limited conversation to collaborators Aug 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-skumbham @sfc-gh-igarish