Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable autocompletion #1109

Merged
merged 2 commits into from
May 24, 2024
Merged

Enable autocompletion #1109

merged 2 commits into from
May 24, 2024

Conversation

sfc-gh-turbaszek
Copy link
Contributor

Pre-review checklist

  • I've confirmed that instructions included in README.md are still correct after my changes in the codebase.
  • I've added or updated automated unit tests to verify correctness of my new code.
  • I've added or updated integration tests to verify correctness of my new code.
  • I've confirmed that my changes are working by executing CLI's commands manually.
  • I've confirmed that my changes are up-to-date with the target branch.
  • I've described my changes in the release notes.
  • I've described my changes in the section below.

Changes description

Enable built-in feature of completion

@sfc-gh-turbaszek sfc-gh-turbaszek requested review from a team as code owners May 24, 2024 09:53
sfc-gh-pjob
sfc-gh-pjob previously approved these changes May 24, 2024
View reviewed changes
@sfc-gh-pjob sfc-gh-pjob dismissed their stale review May 24, 2024 10:07

Forgot to check pre-review checklist ;)

@sfc-gh-pjob
Copy link
Contributor

Please update release notes

@sfc-gh-turbaszek sfc-gh-turbaszek merged commit 3c687a7 into main May 24, 2024
23 checks passed
@sfc-gh-turbaszek sfc-gh-turbaszek deleted the enable-completion branch May 24, 2024 10:55
@sfc-gh-turbaszek sfc-gh-turbaszek mentioned this pull request May 28, 2024
Closed
sfc-gh-sichen pushed a commit that referenced this pull request Oct 17, 2024
@sfc-gh-turbaszek
Enable autocompletion (#1109)
4a0a118
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-pjob sfc-gh-pjob sfc-gh-pjob approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-turbaszek @sfc-gh-pjob