Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated version #686

Merged
merged 2 commits into from
Feb 28, 2024
Merged

updated version #686

merged 2 commits into from
Feb 28, 2024

Conversation

sfc-gh-dshah
Copy link
Collaborator

Updated version from 2.1.0 to 2.1.0-SNAPSHOT to support streaming ingest benchmark testing.

pom.xml Outdated
@@ -6,7 +6,7 @@
<!-- Arifact name and version information -->
<groupId>net.snowflake</groupId>
<artifactId>snowflake-ingest-sdk</artifactId>
<version>2.1.0</version>
<version>2.1.0-SNAPSHOT</version>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be 2.1.1-SNAPSHOT, and please update the pom file in e2e test folder as well

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfc-gh-tzhang addressed PR comments.

Copy link
Contributor

@sfc-gh-tzhang sfc-gh-tzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sfc-gh-dshah sfc-gh-dshah merged commit 2cd808b into master Feb 28, 2024
14 checks passed
@sfc-gh-dshah sfc-gh-dshah deleted the update_version branch February 28, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants