Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1491254 AST generation for DataFrame analytics functions #1988

Conversation

sfc-gh-vbudati
Copy link
Contributor

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1491254

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
  3. Please describe how your code solves the related issue.

Added AST generation for moving_agg, cumulative_agg, compute_lag, compute_lead, and time_series_agg for DataFrame.analytics.

All of the DataFrame.analytics functions have a parameter col_formatter which is an optional Callable parameter to format the output column names. Since this computation is done on the client, the AST does not record the callable; instead, it records the generated column names.

-df-analytics-functions

# Conflicts:
#	src/snowflake/snowpark/_internal/proto/ast_pb2.py
-df-analytics-functions

# Conflicts:
#	src/snowflake/snowpark/_internal/proto/ast_pb2.py
@sfc-gh-vbudati
Copy link
Contributor Author

Associated JIRA to record the formatted column names: https://snowflakecomputing.atlassian.net/browse/SNOW-1559381

@sfc-gh-vbudati sfc-gh-vbudati merged commit 3ec266e into server-side-snowpark Jul 27, 2024
12 of 14 checks passed
@sfc-gh-vbudati sfc-gh-vbudati deleted the vbudati/SNOW-1491254-df-analytics-functions branch July 27, 2024 00:11
@github-actions github-actions bot locked and limited conversation to collaborators Jul 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants