Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow mouse input to propagate from panels #44

Closed
wants to merge 1 commit into from
Closed

Allow mouse input to propagate from panels #44

wants to merge 1 commit into from

Conversation

anissen
Copy link
Contributor

@anissen anissen commented Mar 1, 2016

No description provided.

@anissen anissen mentioned this pull request May 13, 2016
Closed
@ruby0x1
Copy link
Member

ruby0x1 commented May 13, 2016

Sorry for the delayed reply!

This change unfortunately is not currently in line with the intent of the flag or the panel control. It's a bit of a band aid, the real issue is elsewhere in the focus model, which I'm dealing with instead. If the issue was more than just setting a bool in the constructor or after creating I would have merged this but I wanted to get to the root issue, as it creates more problems than just convenience ( like #49 ).

It should be resolved soon either way, thanks for the PR of course!

@anissen anissen closed this Sep 3, 2016
@ruby0x1
Copy link
Member

ruby0x1 commented Sep 3, 2016

I'm still working on a solution for this btw. As is typical with UI there seems to be an entanglement of concerns. When you fix one issue (i.e moving the mouse_input test out of topmost_control_at_point) it creates new issues elsewhere (i.e the marked state and captured state conflict because they can now see things they couldn't before).

It requires a bottom of consideration of the focus model as a whole, which is where the solution needs to be. Coincidentally I've been working on this just earlier today and hoping to have a good solution in later.

@ruby0x1 ruby0x1 mentioned this pull request Sep 6, 2016
Closed
ruby0x1 added a commit that referenced this pull request Sep 6, 2016
@ruby0x1
Focus; fix default focus model event propagation #52
4f0e9ce 
fix #52
fix #49
fix #37
related #44
@ruby0x1
Copy link
Member

ruby0x1 commented Sep 6, 2016 •
edited
Loading

This should be better now, see the referenced issue, thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anissen @ruby0x1