Skip to content
This repository has been archived by the owner on Aug 2, 2020. It is now read-only.

Implement build rules for includes #39

Closed
snowleopard opened this issue Dec 25, 2015 · 14 comments · Fixed by #58
Closed

Implement build rules for includes #39

snowleopard opened this issue Dec 25, 2015 · 14 comments · Fixed by #58
Assignees

Comments

@snowleopard
Copy link
Owner

See #16.

The following files need to be generated:

  • includes/ghcautoconf.h Done: 6b7b9cc.
  • includes/ghcplatform.h Done: 8c32f2c.
  • includes/ghcversion.h Done: 66f18be.
  • includes/dist-derivedconstants/header/DerivedConstants.h Done: c6cfb36.
  • includes/dist-derivedconstants/header/GHCConstantsHaskellType.hs Done: c6cfb36.
  • includes/dist-derivedconstants/header/platformConstants Done: c6cfb36.
  • includes/dist-derivedconstants/header/GHCConstantsHaskellWrappers.hs Done: c6cfb36.
  • includes/dist-derivedconstants/header/GHCConstantsHaskellExports.hs Done: c6cfb36.

Please add other includes files that need attention to the above list.

@snowleopard
Copy link
Owner Author

As the first step I improved the infrastructure we have for generated files: now generators live in directory Rules/Generators/ and we track changes in them. The relevant commit: 8c3022d.

@snowleopard
Copy link
Owner Author

We can now generate includes/ghcautoconf.h: 6b7b9cc.

@angerman
Copy link
Collaborator

Going to give this a try shortly.

On Dec 26, 2015, at 11:06 AM, Andrey Mokhov notifications@github.com wrote:

We can now generate includes/ghcautoconf.h :6b7b9cc.


Reply to this email directly or view it on GitHub.

@angerman
Copy link
Collaborator

Now we are missing `includes/ghcplatform.h" :-)

@snowleopard
Copy link
Owner Author

@angerman Done :-) See 8c32f2c.

That's probably enough for today. The next one is includes/ghcversion.h. I'll work on it tomorrow unless anyone picks it up earlier.

@angerman
Copy link
Collaborator

Ha, I was just going to give this a try. Well done! I’ll see if I can get includes/ghcversion.h then :D

On Dec 26, 2015, at 11:43 AM, Andrey Mokhov notifications@github.com wrote:

@angerman Done :-) See 8c32f2c.

That's probably enough for today. The next one is includes/ghcversion.h. I'll work on it tomorrow unless anyone picks it up earlier.


Reply to this email directly or view it on GitHub.

@snowleopard
Copy link
Owner Author

@angerman Thanks! All infrastructure is in place, so this should be fairly straightforward, but a bit tedious.

@snowleopard
Copy link
Owner Author

Another file to generate: includes/dist-derivedconstants/header/GHCConstantsHaskellExports.hs (#53).

@angerman
Copy link
Collaborator

Another file to generate: includes/dist-derivedconstants/header/GHCConstantsHaskellExports.hs (#53).

Wouldn't that live in compiler/includes/dist-derivedconstants/header/GHCConstantsHaskellExports.hs?

@snowleopard
Copy link
Owner Author

@angerman I don't see any includes directory in compiler.

I think we are talking about includes/dist-derivedconstants/header/GHCConstantsHaskellExports.hs.

@snowleopard
Copy link
Owner Author

OK, I think I've done all includes apart from includes/ghcversion.h.

@angerman, this is now up to you to finish :-)

@snowleopard snowleopard assigned angerman and unassigned snowleopard Dec 27, 2015
@angerman
Copy link
Collaborator

Adding pressure. I see. Alright, I'll give it a show now.

@snowleopard
Copy link
Owner Author

There may be some other files we missed, but I'm closing this for now.

@snowleopard
Copy link
Owner Author

I've done a test build, everything works fine. However, we are not needing includes/ghcversion.h anywhere in the system yet.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants