Skip to content
This repository has been archived by the owner on Aug 2, 2020. It is now read-only.

fix missing symbols when cross-compiling #583

Merged
merged 1 commit into from
Apr 27, 2018
Merged

fix missing symbols when cross-compiling #583

merged 1 commit into from
Apr 27, 2018

Conversation

izgzhen
Copy link
Collaborator

@izgzhen izgzhen commented Apr 26, 2018

fixes #581

@izgzhen
Copy link
Collaborator Author

izgzhen commented Apr 26, 2018

I am actually reverting a change I've done in https://github.com/snowleopard/hadrian/pull/401/files. I tried to understand what is my motivation but found it hard to justify this by comparing to the latest HEAD. I think we can merge this as long as CI passed and no one jumps out and objects it.

@@ -31,7 +31,7 @@ cIncludeArgs = do

cross <- expr crossCompiling
compilerOrGhc <- package compiler ||^ package ghc
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines (cross, compilerOrGhc) can be removed now as well, right?

Copy link
Collaborator

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can drop some more dead code, no? Otherwise LGTM.

@snowleopard
Copy link
Owner

snowleopard commented Apr 26, 2018

I think we should just make one of the CI instances (e.g. the selftest one) fail if there are any warnings. In this case there are warnings about unused code, which is difficult to spot while reviewing a PR, but easy to check by the compiler. Perhaps, we could also hook up @ndmitchell's Weeder :)

@izgzhen
Copy link
Collaborator Author

izgzhen commented Apr 27, 2018

@angerman I've updated the code, thanks! I guess there will inevitably be some dead code, but let's do it when we have to.

@snowleopard Dead code check is a good idea! #584

@snowleopard snowleopard merged commit fcc62d1 into snowleopard:master Apr 27, 2018
@snowleopard
Copy link
Owner

@izgzhen Thanks, merged!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

missing symbols defined in includes/rts/Bytecodes.h when cross-compiling
3 participants