-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multi-get #42
Comments
One suggestion is to treat this as part of the catalog, and with the catalog you have the option of just returning keys, or returning keys and bodies. Make sense Ben? Good idea? |
Imo, this is a normal evolution of the api and I had given some thought to it. In my mind the url format would be comma-separated like so:
This is the format used by the api I wrote a wrapper for, so this seems to be pretty standard. Consequently, this would be a bit different from the catalog, but the on/off switch for getting the whole thing or just the keys is a good idea as well. |
Makes sense Ben. Just to confirm, would we support completely orthogonal schemas too:
This would seem to be a requirement |
This would be doable but this seems to be a bit convoluted. Then again maybe there is better approach url-wise to this feature but I can't think of one right now. |
Hmm yeah. Actually my suggestion wouldn't work with the comma syntax, we would need another character to indicate a list versus a tree:
Separately, this would be a powerful thing to support:
e.g.
Not sure about the trailing hyphens |
This is mostly done.
Or in a catalog way:
The combination of everything is also supported:
The following cases still need to be supported:
|
Great work Ben! |
One thing I was wondering about regarding multi get for vendor like this one:
If the owner making the request doesn't own one of those vendors do we send back a 401 or only the schemas he does own? |
Added support for vendor-based multi get like:
and
I chose to send back a 401 if you do not own every vendor requested for now. |
Agree, I think a failure "outranks" a success, and so a 401 should be returned. |
Multi get for full paths are now supported:
Regarding multi get for partial version like:
I dont have a clean way of doing it yet. |
#57 spin off for partial version multi get. |
Done in r2, closing. |
This is an interesting one.
There are Iglu users who want to fetch schemas from Iglu in the browser. In the absence of an iglu-javascript-client, they are handrolling this support for now.
Their requirement on Iglu server is an interesting one: they will not be allowed to do multiple AJAX requests, one per schema, so instead would like a multi-get. This is where we would come up with a syntax for requesting multiple schemas at a time, and then the response would likely be something like this:
Then the Iglu user can cache all of those schemas in LocalStorage.
@BenFradet:
The text was updated successfully, but these errors were encountered: