Allow customizing max header length #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snoyberg
approved these changes
Aug 21, 2023
| @@ -879,3 +882,9 @@ data StreamFileStatus = StreamFileStatus | |||
| , thisChunkSize :: Int | |||
| } | |||
| deriving (Eq, Show, Ord, T.Typeable) | |||
|
|
|||
| -- | The maximum header size in bytes. | |||
There was a problem hiding this comment.
Can you add a @since comment here? And to go along with that: can you add a minor version bump in the cabal file and a changelog entry?
snoyberg
added a commit
that referenced
this pull request
Aug 21, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #502.
I'm not sure if this is the right way to add this customization. I turned the constant into a parameter and then just kept adding parameters until the compiler was happy. Then I pushed the configuration into the
Managersince that felt like the right place to put it.Some of the function signatures could be cleaner if this configuration was contained in the
Connection, but that didn't feel like the right place for this — for whatever reason. Also I have no idea how important it is to have a stable API for these functions. As a user ofhttp-client, I basically only ever usenewManagerandhttpLbs.I'm very much open to feedback here! Please let me know if I can change anything to make this easier to merge.