Adds shouldStripHeaderOnRedirectIfOnDifferentHostOnly
option on Request
#520
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR,
shouldStripHeaderOnRedirectIfOnDifferentHostOnly
option toRequest
getRedirectedRequest
signature to include originalRequest
Why?
Many stdlib in other language and ecosystem offer this functionality by default - refer to
golang
andpython-requests
for example. Potentially leaking headers to different host can lead to security incident. Refer to Python's CVE re this: https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2018-20060Ideally,
shouldStripHeaderOnRedirect
should have only stripped headers if the host differed, so without breaking change, this seems to be second best option.Previous discussion on this topic: #300
Testing
Remaining