Pretty-print of UnexpectedEvent is backward

[khumba]

Hello! In Data.Yaml.Internal:

data ParseException = ...
                    | UnexpectedEvent { _received :: Maybe Event
                                      , _expected :: Maybe Event
                                      }

prettyPrintParseException :: ParseException -> String
prettyPrintParseException pe = case pe of
  ...
  UnexpectedEvent mbExpected mbUnexpected -> unlines
    [ "Unexpected event: expected"
    , "  " ++ show mbExpected
    , "but received"
    , "  " ++ show mbUnexpected
    ]

The fields appear to be in reverse order in UnexpectedEvent mbExpected mbUnexpected; at least, the error message I'm seeing doesn't make a lot of sense as is :).

[snoyberg]

Could catch, can you send a PR to fix that?

On Thu, Jun 9, 2016 at 8:47 AM, Bryan Gardiner notifications@github.com
wrote:

Hello! In Data.Yaml.Internal:

data ParseException = ...
| UnexpectedEvent { _received :: Maybe Event
, _expected :: Maybe Event
}

prettyPrintParseException :: ParseException -> String
prettyPrintParseException pe = case pe of
...
UnexpectedEvent mbExpected mbUnexpected -> unlines
[ "Unexpected event: expected"
, " " ++ show mbExpected
, "but received"
, " " ++ show mbUnexpected
]

The fields appear to be in reverse order in UnexpectedEvent mbExpected
mbUnexpected; at least, the error message I'm seeing doesn't make a lot
of sense as is :).

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#84, or mute the thread
https://github.com/notifications/unsubscribe/AADBBwBYQ0hJfm9isy-ObTCKDCz4Uwb3ks5qJ6j0gaJpZM4Ixpjg
.

[khumba]

Yes, for sure.

On Wed, 08 Jun 2016 23:09:32 -0700
Michael Snoyman notifications@github.com wrote:

Could catch, can you send a PR to fix that?