Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test suite failure (missing file in hackage tarball) #92

Closed
DanBurton opened this issue Aug 31, 2016 · 6 comments

Comments

@DanBurton
Copy link

commented Aug 31, 2016

As seen on the stackage build server:

Failures:

  test/Data/YamlSpec.hs:67:
  1) Data.Yaml.Data.Yaml encode/decode files with non-ASCII names
       uncaught exception: ParseException (InvalidYaml (Just (YamlException "Yaml file not found: test/resources/accent\233/foo.yaml")))

I was able to reproduce locally like so:

$ stack unpack yaml-0.8.18.2
$ cd yaml-0.8.18.2/
$ stack init --resolver nightly-2016-08-31
$ stack test
DanBurton added a commit to commercialhaskell/stackage that referenced this issue Aug 31, 2016
@snoyberg

This comment has been minimized.

Copy link
Owner

commented Aug 31, 2016

0.8.18.3 should solve this.

@snoyberg snoyberg closed this Sep 1, 2016

DanBurton added a commit to commercialhaskell/stackage that referenced this issue Sep 1, 2016
@DanBurton

This comment has been minimized.

Copy link
Author

commented Sep 2, 2016

I'm seeing the same error with 0.8.18.3

@snoyberg

This comment has been minimized.

Copy link
Owner

commented Sep 2, 2016

OK, we need to leave the test disabled for now then. This is a bug in stack unpack (the same bug in the tar package), so we'll need to wait for a new Stack release to fix it. Can I recommend we move this to the stackage issue tracker at this point, since there's nothing we can do in yaml?

@snoyberg

This comment has been minimized.

Copy link
Owner

commented Sep 2, 2016

And it looks like the bug exists in cabal unpack as well, I'll open an issue there.

@snoyberg

This comment has been minimized.

Copy link
Owner

commented Sep 2, 2016

And it turns out that Hackage does not actually support packages which have non-ASCII filenames anyway, I get the following error:

Uploading yaml-0.8.18.4.tar.gz... unhandled status code: 400
Error: Invalid package

The package tarball contains an entry with a non-ASCII file name. For portability, package tarballs should contain only ASCII file names (e.g. not UTF8 encoded Unicode).
Upload failed on yaml-0.8.18.4.tar.gz

I'll work around this in the test suite itself.

@snoyberg snoyberg reopened this Sep 2, 2016

@snoyberg snoyberg closed this in 8749ee6 Sep 2, 2016

@snoyberg

This comment has been minimized.

Copy link
Owner

commented Sep 2, 2016

Alright, should actually be put to rest now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.