Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fdopen link error on Windows #96

Closed
azverkan opened this issue Sep 8, 2016 · 3 comments

Comments

@azverkan
Copy link

commented Sep 8, 2016

Git HEAD currently fails to link on x86_64-windows with: unknown symbol fdopen

Switching from fdopen to _fdopen appears to link and pass the tests at least under Windows 10.

https://msdn.microsoft.com/en-us/library/ms235351.aspx
https://msdn.microsoft.com/en-us/library/dye30d82.aspx

@snoyberg

This comment has been minimized.

Copy link
Owner

commented Sep 9, 2016

I think s/fdopen/_fdopen should be fine. Would you be able to test it on your machine? I can push a commit now and confirm that it works for AppVeyor.

Pinging @Blaisorblade.

snoyberg added a commit that referenced this issue Sep 9, 2016
@Blaisorblade

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2016

I know no objection against _fdopen, and I can confirm the failure on a Win 10 64bit VM with 64 bit stack. AppVeyor tests only with 32bit stack.* Testing on both options would probably be an appropriate response, even though it feels overkill... for no good reason.

*I'm not sure why it worked before, but I suspect it's because of using 32bit stack (on a 64 bit Windows). I think I can rule out a 32bit Windows because I can't find any 32bit IEVM for Win10, but I'm positive I've used 32bit stack.

@snoyberg

This comment has been minimized.

Copy link
Owner

commented Sep 9, 2016

Thanks for confirming, new version uploaded.

@snoyberg snoyberg closed this Sep 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.