Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode empty inputs as Null #101

Merged
merged 1 commit into from Nov 27, 2016

Conversation

Projects
None yet
2 participants
@liskin
Copy link
Contributor

commented Nov 25, 2016

In my opinion, empty and comment only files are perfectly valid inputs for
Data.Yaml.Config.loadYamlSettings and I don't see why they'd not be valid
inputs for Data.Yaml.decode as well so I fixed it there.

Decode empty inputs as Null
In my opinion, empty and comment only files are perfectly valid inputs
for `Data.Yaml.Config.loadYamlSettings` and I don't see why they'd not
be valid inputs for `Data.Yaml.decode` as well so I fixed it there.
@snoyberg

This comment has been minimized.

Copy link
Owner

commented Nov 27, 2016

Seems reasonable, and in line with what other languages seem to do after a basic review. Thanks!

@snoyberg snoyberg merged commit 08c123b into snoyberg:master Nov 27, 2016

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

snoyberg added a commit that referenced this pull request Nov 27, 2016

@liskin liskin deleted the liskin:empty-inputs branch Nov 27, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.