Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decode empty inputs as Null #101

Merged
merged 1 commit into from
Nov 27, 2016
Merged

Decode empty inputs as Null #101

merged 1 commit into from
Nov 27, 2016

Conversation

liskin
Copy link
Contributor

@liskin liskin commented Nov 25, 2016

In my opinion, empty and comment only files are perfectly valid inputs for
Data.Yaml.Config.loadYamlSettings and I don't see why they'd not be valid
inputs for Data.Yaml.decode as well so I fixed it there.

In my opinion, empty and comment only files are perfectly valid inputs
for `Data.Yaml.Config.loadYamlSettings` and I don't see why they'd not
be valid inputs for `Data.Yaml.decode` as well so I fixed it there.
@snoyberg
Copy link
Owner

Seems reasonable, and in line with what other languages seem to do after a basic review. Thanks!

@snoyberg snoyberg merged commit 08c123b into snoyberg:master Nov 27, 2016
snoyberg added a commit that referenced this pull request Nov 27, 2016
@liskin liskin deleted the empty-inputs branch November 27, 2016 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants