Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close #157. Return start and end marks for all events. #159

Merged
merged 3 commits into from
Oct 10, 2018
Merged

Close #157. Return start and end marks for all events. #159

merged 3 commits into from
Oct 10, 2018

Conversation

afranchuk
Copy link

Adds decodeMarked and decodeFileMarked functions, which return conduits yielding MarkedEvent instances.

Close snoyberg#157. Return start and end marks for all events.
91c6658 
Adds decodeMarked and decodeFileMarked functions.
@afranchuk
Copy link
Author

The new constructor and functions have empty @since annotations that should be populated when appropriate.

snoyberg
snoyberg requested changes Oct 9, 2018
View reviewed changes
Copy link
Owner

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just some minor comments.

src/Text/Libyaml.hs Outdated Show resolved Hide resolved
src/Text/Libyaml.hs Outdated Show resolved Hide resolved
src/Text/Libyaml.hs Show resolved Hide resolved
snoyberg
snoyberg approved these changes Oct 10, 2018
View reviewed changes
Copy link
Owner

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snoyberg snoyberg merged commit 7682a3c into snoyberg:master Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snoyberg snoyberg snoyberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@afranchuk @snoyberg