Fix #195: options --help and --version #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove conditional semigroups dependency - add -Wall and -Wcompat (GHC 8) to all goals
Using optparse-applicative, let yaml2json understand options
--help | -h
--version | -V | --numeric-version
in a robust way.
Otherwise, no change of cmdline syntax:
yaml2json file.yml # read from file
yaml2json - # read from stdin
Tested build with GHC 8.0 - 9.0.
|
Looks great! I'm adding a ChangeLog entry and version bump. From your last comment, it sounds like you're planning a follow-up PR for |
Very good! I get to work asap! |
This was referenced Sep 15, 2021
See #198. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #195: options --help and --version
Preparatory patch: Since we have GHC>=8 (base >=4.9), we can simplify package.yaml
yaml2json
Using optparse-applicative, let yaml2json understand options
in a robust way.
Otherwise, no change of cmdline syntax:
Tested build with GHC 8.0 - 9.0.
json2yaml
NYI, if everything is fine with the
yaml2jsonhalf, I implement it forjson2yamllikewise.