Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct signature for fclose #214

Merged
merged 1 commit into from
May 1, 2023
Merged

Correct signature for fclose #214

merged 1 commit into from
May 1, 2023

Conversation

amesgen
Copy link
Contributor

@amesgen amesgen commented Apr 30, 2023

fclose has signature

int fclose(FILE *stream);

Motivation for this PR is the new WASM/WASI backend in GHC 9.6; as the WASM linker is quite strict about signature mismatches.

lvn-rusty-dragon
lvn-rusty-dragon suggested changes May 1, 2023
View reviewed changes
Copy link

@lvn-rusty-dragon lvn-rusty-dragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you add a minor version bump and changelog entry describing the change?

@snoyberg snoyberg merged commit 24b5b9a into snoyberg:master May 1, 2023
@amesgen amesgen deleted the fclose-sig branch May 1, 2023 09:50
@amesgen amesgen mentioned this pull request Jul 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvn-rusty-dragon lvn-rusty-dragon lvn-rusty-dragon requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amesgen @lvn-rusty-dragon @snoyberg