-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aeson under 0.7.0 #70
Conversation
Btw: would you be interested in more "polish" changes? (HLint, ...) |
What's the use case for building with the older versions of aeson? Those versions have some pretty severe DoS security vulnerabilities, so I'd be more tempted to just set a lower bound. Polish patches would be welcome, but please do include them in separate PRs to make the review easier. |
Use case: building with Bumping bounds in cabal file would work too, but then I would strongly suggest cleaning source from all the Main fixing has been done in xkollar@53f54d5 ... others fix residual compiler warnings. If you wish, I can move them to separate PR but I thought they would not hurt in this case as they are in separate commits. (Of course, other polish things would not go into this PR.) |
@@ -97,7 +103,7 @@ number :: Scientific -> YamlBuilder | |||
number = scientific | |||
#else | |||
number :: Number -> YamlBuilder | |||
number n rest = YamlBuilder (EventScalar (S8.pack $ show n) IntTag PlainNoTag Nothing :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type error
PS: Even if you decide for bumping requirements for aeson, please accept this change first... it would feel better. (Then I can do setting of lower bound and removing |
Cool, merged. I'd strongly recommend against sticking with that old version of aeson. If you want to see why, try parsing |
Thank you |
I'll make a point release with the changes you just made. A PR with cleanups and the tightened upper bound would be great, thanks. |
Ok, thanks once again for the very quick response. |
Fixing issue #69 ... plus some polish.