Bugz collector #62
Bugz collector #62
Conversation
| @@ -262,39 +262,43 @@ def subscribe(state, feed, exchange, assets, currencies, interval, channels): | |||
|
|
|||
|
|
|||
| @coin.command() | |||
| @click.option('--market', '-m', default='all') | |||
There was a problem hiding this comment.
Good call. I thought this was getting too complicated.
| type=click.Choice(['None', 'Trade', 'Heartbeat', 'LimitOrder', | ||
| 'CancelOrder'])) | ||
| @click.option('--filters', '-f', default=None, type=str, multiple=True) | ||
| # FIXME: the types should be autogenerated from the Event types |
There was a problem hiding this comment.
That would be cool... but it may also seem like magic...
There was a problem hiding this comment.
Perhaps, but we currently do the same for Feeds and Collectors. That's one of the nice things because you just have to register a new Feed and the CLI help output updates automatically.
There was a problem hiding this comment.
I know, that also seems like magic. The things I have against magic is that takes more time to understand how the infrastructure works as opposed to what it does. This is not to say it's always bad, but often times, it leads to over engineering...
| @click.option('--text', 'format', flag_value='text', default=True) | ||
| @click.option('--json', 'format', flag_value='json') | ||
| @click.option('--interval', '-i', default=None, type=float) | ||
| @pass_state | ||
| def collect(state, market, stream, collector, filter, type, output, format, interval): | ||
| def collect(state, subscriptions, stream, collector, output, filters, types, format, |
There was a problem hiding this comment.
Collect sure has a long argument list...
|
The problem was that at some point I changed the order of the decorators but hadn't adjusted the order of the arguments so options were sent to the wrong arguments. |
Fixes Collector handling of filters and types and adds pattern matching for subscriptions.
@barrysteyn please review