Introduce EMPTY_ARRAY and use it where appropriate

snusnu · Jul 4, 2013 · 43df9e9 · 43df9e9
1 parent 933098e
commit 43df9e9
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/lib/substation.rb b/lib/substation.rb
@@ -31,6 +31,10 @@
 # action.
 
 module Substation
+
+  # An empty frozen array useful for (default) parameters
+  EMPTY_ARRAY = [].freeze
+
 end
 
 require 'substation/utils'

diff --git a/lib/substation/chain.rb b/lib/substation/chain.rb
@@ -72,7 +72,7 @@ class Chain
     include Adamantium::Flat
 
     # Empty chain
-    EMPTY = Class.new(self).new([])
+    EMPTY = Class.new(self).new(EMPTY_ARRAY)
 
     # Call the chain
     #

diff --git a/lib/substation/chain/dsl.rb b/lib/substation/chain/dsl.rb
@@ -129,7 +129,7 @@ def self.build(*blocks)
       #
       # @api private
       def self.coerce(*blocks)
-        blocks.compact.inject(new(Chain::EMPTY)) { |dsl, block|
+        blocks.compact.inject(new(EMPTY_ARRAY)) { |dsl, block|
           dsl.instance_eval(&block)
         }
       end