Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] Process local update operation through operation queue #10

Merged
merged 2 commits into from
Dec 25, 2017

Conversation

wynot12
Copy link
Contributor

@wynot12 wynot12 commented Dec 25, 2017

This PR fixes the data consistency problem in the PS-collocation mode of Dolphin-on-ET.
Especially LDA app fails with EOFException, since its model array's length varies in runtime.

ET allows bypassing of operation queue when the operation is for local blocks.
It's quite efficient, since it minimizes overheads in data access.

However, allowing bypass to update operation has a problem, since this operation should be atomic. Without operation queueing, the operation is not guaranteed to be atomic.

This PR simply eliminates the problem by changing ET's update operation to use the remote access's routine also for local access.
However, it has unnecessary overheads in (de)serialization of key and update values, (and passing through loopback network interface; I have no idea about how much overhead it has.).
Let's optimize this part later, since it's not much critical.

@yunseong
Copy link
Contributor

Thanks for the PR! I'm so glad that this change fixes the correctness issue we've suffered.
I'll merge this.

@yunseong yunseong merged commit 48f3f1b into master Dec 25, 2017
@yunseong yunseong deleted the update-op-queue branch December 25, 2017 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants