[MINOR] Process local update operation through operation queue #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the data consistency problem in the PS-collocation mode of Dolphin-on-ET.
Especially LDA app fails with EOFException, since its model array's length varies in runtime.
ET allows bypassing of operation queue when the operation is for local blocks.
It's quite efficient, since it minimizes overheads in data access.
However, allowing bypass to update operation has a problem, since this operation should be atomic. Without operation queueing, the operation is not guaranteed to be atomic.
This PR simply eliminates the problem by changing ET's update operation to use the remote access's routine also for local access.
However, it has unnecessary overheads in (de)serialization of key and update values, (and passing through loopback network interface; I have no idea about how much overhead it has.).
Let's optimize this part later, since it's not much critical.